Use a larger buffer for variable data. #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, there seems to be no issue on NodeJS 5.9.1 which I tried today, but newer versions (6.4.0 for example) trigger the ArrayOutOfBound exception. Maybe these newer versions check array overflows more strictly... |
|
Is this related to #431? |
|
Yes it definitely is! If you think there is no reason for the connection data to be larger than 200 characters in any situation then you can close the pull request. Thanks. |
|
As this is a bug in Node 6.4.0 and will be fixed in 6.4.1, I'll close this. Many thanks for putting in the work here anyway! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Recently I started to get
RangeError: Offset is out of boundserrors while starting my server, and it started just after I moved the server to a new address.I debugged the issue, and found that the length of the content in variableData (see code change) is 263, which is too large for the allocated 200.
I hope this fix is fine for you and you can produce a new tagged version very soon.
Thank you very much.
Regards,
Nicolas