Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useSSHSourceFormat option to configure source URL format in Wiki documentation #146

Merged

Conversation

virgofx
Copy link
Member

@virgofx virgofx commented Feb 7, 2025

This pull request introduces a new configuration option to use SSH format for source links in generated Wiki documentation, along with several related updates across the codebase. Here are the most important changes:

Configuration Updates:

  • Added use-ssh-source-format option to the configuration, allowing users to choose between SSH and HTTPS formats for source links in Wiki documentation (.github/workflows/ci.yml, action.yml, src/types/index.ts, src/config.ts). [1] [2] [3] [4]

Documentation and Workflow Changes:

  • Updated the README.md to include the new use-ssh-source-format parameter and its description. [1] [2]
  • Changed the workflow in .github/workflows/test.yml to use SonarQube Scan instead of SonarCloud Scan.

Code and Test Updates:

  • Modified __mocks__/config.ts and __tests__/config.test.ts to support and test the new use-ssh-source-format configuration option. [1] [2] [3]
  • Added tests in __tests__/wiki.test.ts to ensure correct formatting of source URLs based on the useSSHSourceFormat setting.

Implementation Details:

  • Implemented the formatModuleSource function in src/wiki.ts to format source URLs based on the new configuration setting. [1] [2]

These changes collectively enhance the flexibility and configurability of the module by allowing users to specify their preferred source URL format in the generated Wiki documentation.


Fixes #136

@virgofx virgofx force-pushed the 136-allow-customizing-the-source-string-generated-in-the-wiki branch 7 times, most recently from 1a3cbf2 to e0d88c8 Compare February 7, 2025 07:38
@virgofx virgofx force-pushed the 136-allow-customizing-the-source-string-generated-in-the-wiki branch from e0d88c8 to cb4f505 Compare February 7, 2025 07:41
@virgofx virgofx force-pushed the 136-allow-customizing-the-source-string-generated-in-the-wiki branch from cb4f505 to 4047b8b Compare February 7, 2025 07:42
Copy link

github-actions bot commented Feb 7, 2025

Release Plan

No terraform modules updated in this pull request.

✅ Wiki Check ℹ️

Note: The following Terraform modules no longer exist in source; however, corresponding tags/releases exist. Automation tag/release deletion is disabledno subsequent action will take place.

v1.3.1, v1.3.0, v1.2.0, v1.1.1, v1.1.0, v1.0.1, v1.0.0, v1

Powered by techpivot/terraform-module-releaser

@virgofx virgofx merged commit fb751d4 into main Feb 8, 2025
26 checks passed
@virgofx virgofx deleted the 136-allow-customizing-the-source-string-generated-in-the-wiki branch February 8, 2025 06:43
@release-preview release-preview bot mentioned this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customizing the source string generated in the wiki
1 participant