Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Spotless format to be closer to the IntelliJ default #47

Merged
merged 1 commit into from
May 31, 2024

Conversation

xpmatteo-tw
Copy link
Contributor

What is being fixed - and why?

The current format forced by the Spotless plugin is the Google format, that indents to 2 spaces. IntelliJ default is 4 spaces, which makes it awkward to work in the codebase.

I can also say that the Google format breaks lines too much, making them harder to read, at least the way I am used to read code.

I think we should avoid adding distractions to the interview by using an unusual format in the codebase.

What has changed?

I moved to the Palantir format, that mostly is the same as the one IntelliJ uses by default. The order of imports is different, but this should be a difficulty for the interviewer or the candidate.

@jejking-tw
Copy link
Contributor

👍🏻 Thanks @xpmatteo-tw

@jejking-tw jejking-tw merged commit 1b19aa4 into techops-recsys-lateral-hiring:main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants