Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciling timing of project prepping and test namespace discovery #1782

Closed
cemerick opened this issue Dec 8, 2014 · 3 comments
Closed

Comments

@cemerick
Copy link
Collaborator

cemerick commented Dec 8, 2014

If a task added to :prep-tasks generates sources containing tests, those test namespaces will not be run because leiningen.test performs its namespace discovery before eval-in-project (and therefore :prep-tasks tasks) is run.

A real-world example of this is cljx (described more completely with a workaround here), which is moving away from hooks to use :prep-tasks (as advised here).

How can this be reconciled?

@technomancy
Copy link
Owner

I'd be open to an explicit prep call before the test namespaces are calculated. There should be very little cost to prepping more than once.

@cemerick
Copy link
Collaborator Author

cemerick commented Dec 9, 2014

Sounds good. It's not an issue I personally have, but I've left breadcrumbs for those potentially affected to pick this up. Thanks, Phil.

@hypirion
Copy link
Collaborator

Fixed by #2165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants