refactor: simplify the stats page and its components #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raphael-arce
force-pushed
the
refactor/stats
branch
from
a93afab
to
286b270
Compare
|
@raphael-arce thanks for your effort :) Looks good! But for me, the preview link is not working - it does not render the charts. Do you know whats up? The |
|
@Jaszkowic hmm i don't know whats wrong. Locally it works. Will look into it 👍 |
Signed-off-by: Raphael Arce <raphael.arce@ts.berlin>
raphael-arce
force-pushed
the
refactor/stats
branch
from
286b270
to
cb44226
Compare
|
@Jaszkowic found the issue and fixed it 👍 the resize function was called before the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to simplify / make the components more readable. @aeschi @Jaszkowic let me know what you think :)
(I also added a missing translation for "Andere" in the donut chart and fixed a visual bug when you would hover the legend in the "Gießverhalten" chart)