Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/auth confirm #577

Merged
merged 9 commits into from
May 10, 2023
Merged

fix/auth confirm #577

merged 9 commits into from
May 10, 2023

Conversation

ff6347
Copy link
Collaborator

@ff6347 ff6347 commented May 9, 2023

This PR adds the missing confirm view to instruct the users to look into their inbox for a mail from the newly added env var NEXT_PUBLIC_FROM_EMAIL. Variable is already added to vercel.com

Also fixes typographically wrong quotes

  • fix(auth): Add confirm view
  • fix: Add typographically correct quotes for de
  • fix: Use the right quotes
  • style: Add spacer between text and notification
  • chore: Add FROM_EMAIL as env var

2023-05-09 11 26 34

@ff6347 ff6347 requested review from dnsos and vogelino as code owners May 9, 2023 09:30
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 9:59am

Copy link
Contributor

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of suggestions and one open question

src/components/Sidebar/SidebarAuth/index.tsx Outdated Show resolved Hide resolved
src/components/Sidebar/SidebarAuth/index.tsx Outdated Show resolved Hide resolved
src/components/Sidebar/SidebarAuth/index.tsx Outdated Show resolved Hide resolved
src/components/Sidebar/SidebarAuth/index.tsx Outdated Show resolved Hide resolved
rather then notifiction. Also does some housekeeping
Copy link
Contributor

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks! Looks amazing 👍

@ff6347 ff6347 merged commit 35f20e0 into feat/auth-via-supabase May 10, 2023
@ff6347 ff6347 deleted the fix/auth-confirm branch May 10, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants