-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consume dynamic env vars from SSM rather than env vars [CHI-2897] #801
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 641f4c9.
…meters, removed default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the naming thing. Looks good otherwise
@@ -0,0 +1,66 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert this back to the correct file naming convention? i.e. camel case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, given it's specialised nature, perhaps we could call it something like ssmConfigurationCache?
This PR completes the migrations of https://github.com/techmatters/infrastructure-config/pull/407 and techmatters/flex-plugins#2673.
Description
This PR
packages/twilio-worker-auth/src/twilioWorkerAuthMiddleware.ts
):authTokenLookup
andstaticKeyLookup
are required as parameters, with no "defaults" being configured.auth_token
andstatic_key
parameters.permission_config
parameter.defaultAuthSecretsLookup
(defined in HRM core), but should be rather trivial to pass the resources secrets once this service is isolated.Note: all of the above is "added on top" of the environment variables. If the env vars are still provisioned via the env vars file, nothing will change, except that there's some extra "async" code around.
Once https://github.com/techmatters/infrastructure-config/pull/410 is applied, and the env vars are not provisioned from S3 anymore, the SSM reading logic will kick in.
Checklist
Verification steps
Is easier to deploy to development and test there. Configuring local environment to test this changes is time consuming. I'm happy to explain how to, if that's really desired, since I can quickly share the needed secrets.
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P