Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-2833: transcript scrubbing integration tests #714

Merged
merged 29 commits into from
Aug 23, 2024

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Aug 7, 2024

Description

  • Adds integration tests for the transcript scrubber that pass locally, but still have issues in CI
  • Fixes for transcript scrubber for issues highlighted by integration tests
  • Creates an integration testing project. In future we should move integration tests here

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags / configuration added

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

# Conflicts:
#	hrm-domain/hrm-core/contact-job/contact-job-complete.ts
@stephenhand stephenhand marked this pull request as ready for review August 23, 2024 13:23
@stephenhand stephenhand merged commit cf253be into master Aug 23, 2024
11 checks passed
@stephenhand stephenhand deleted the CHI-2833-integration_tests branch August 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant