refactor: better math

techmatters · Sep 26, 2024 · 151404c · 151404c
1 parent d9f44c5
commit 151404c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/hrm-domain/packages/hrm-search-config/generateElasticsearchQuery.ts b/hrm-domain/packages/hrm-search-config/generateElasticsearchQuery.ts
@@ -33,7 +33,7 @@ const BOOST_FACTORS = {
   case: 3,
 };
 const MIN_SCORE = 0.1;
-const MAX_INT = 2147483648; // 2^31, the max integer allowed by ElasticSearch integer type
+const MAX_INT = 2147483648 - 1; // 2^31 - 1, the max integer allowed by ElasticSearch integer type
 
 export const FILTER_ALL_CLAUSE: QueryDslQueryContainer[][] = [
   [
@@ -205,7 +205,7 @@ const generateQueriesFromId = <TDoc extends DocumentType>({
       const parsed = Number.parseInt(term, 10);
 
       // Ignore numbers that are greater than maximum supported int
-      if (parsed >= MAX_INT) {
+      if (parsed > MAX_INT) {
         return null;
       }