Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš‘ Change Contribution count method #28

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

l2hyunwoo
Copy link
Contributor

What does this PR do?

์ž”๋”” ์•ฑ์—์„œ ์ปค๋ฐ‹ ์นด์šดํŠธ๋ฅผ ๊ฐ€์ ธ์˜ค๋Š” ๋ฐฉ๋ฒ•์— ์ˆ˜์ •์„ ๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Why are we doing this?

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-01-10 แ„‹แ…ฉแ„’แ…ฎ 2 59 02

ํ˜„์žฌ ์ฝ”๋“œ๋Œ€๋กœ ์ปค๋ฐ‹์„ ๊ฐ€์ ธ์˜ฌ ๊ฒฝ์šฐ ์œ ์ €์˜ ์ปค๋ฐ‹ ์นด์šดํŠธ๊ฐ€ ์•„๋‹Œ ๋‹ค๋ฅธ ์ˆซ์ž๋ฅผ ์ฐธ์กฐํ•˜์—ฌ ์ปค๋ฐ‹์„ ๊ฐ€์ ธ์˜ค๊ฒŒ ๋ฉ๋‹ˆ๋‹ค. ๋”ฐ๋ผ์„œ html element ๋‚ด์˜ text๋ฅผ ํŒŒ์‹ฑํ•ด์„œ ๊ฐ€์žฅ ์•ž์— ์˜ค๋Š” ๋ฌธ์ž์—ด์„ ์ •์ˆ˜๋กœ ๋ฐ”๊ฟ”์„œ ๊ฐ€์ ธ์˜ค๋Š” ๋กœ์ง์œผ๋กœ ์ปค๋ฐ‹ ์นด์šดํŠธ๋ฅผ ๊ฐ€์ ธ์˜ค๋Š” ๋ฐฉ์‹์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

@techinpark techinpark self-requested a review January 10, 2023 17:46
Copy link
Owner

@techinpark techinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l2hyunwoo ์ƒ๊ฐํ•˜์ง€ ๋ชปํ–ˆ๋˜ ์ด์Šˆ๋„ค์š”! ๊ธฐ์—ฌํ•ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. ๋‹ค๋งŒ ํ™•์ธ์„ ์ข€ ํ•ด๋ณด๋‹ˆ ์ •๊ทœ์‹์œผ๋กœ ๊ฐ€์ ธ์˜ค๋Š” ๋ถ€๋ถ„์— ์žˆ์–ด์„œ ์ปค๋ฐ‹์ด ์—†๋Š” ๊ฒฝ์šฐ 0 ๊ฐœ๊ฐ€ ๋ฐ˜์˜์ด ๋˜์–ด์•ผ ํ•˜๋Š”๋ฐ ์ •๊ทœ์‹ ํŒจํ„ด์— ์˜ํ•ด์„œ ๋‚ ์งœ๊ฐ€ ํŒŒ์‹ฑ์ด ๋˜์–ด๋ฒ„๋ฆฌ๋Š” ํ˜„์ƒ์ด ์žˆ๋„ค์š”! ์ด๋ถ€๋ถ„๋งŒ๊ฐœ์„ ์ด ๋˜๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค

image

@l2hyunwoo
Copy link
Contributor Author

@techinpark ๋ฆฌ๋ทฐ ๋ฐ˜์˜ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋ฌธ์žฅ ์ฒซ๋ฒˆ์งธ ์–ด์ ˆ์„ ๊ฐ€์ ธ์˜ค๊ณ  ์ด๋ฅผ Int๋กœ ๋ณ€ํ™˜ํ•˜์—ฌ nil์ธ ๊ฒฝ์šฐ 0์„, ๋ณ€ํ™˜ํ•  ์ˆ˜ ์žˆ๋Š” ๊ฒฝ์šฐ์—๋Š” ๊ทธ๊ฐ’์„ ๊ทธ๋Œ€๋กœ ๊ฐ€์ ธ์™€์„œ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๊ฒŒ ๋กœ์ง์„ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.

@techinpark techinpark self-requested a review January 11, 2023 08:36
Copy link
Owner

@techinpark techinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค! ๊ธฐ์—ฌํ•ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ด์š” ๐ŸŽ‰

@techinpark techinpark merged commit a09fbb0 into techinpark:main Jan 11, 2023
@l2hyunwoo l2hyunwoo deleted the feature/fix-contibution-count branch January 11, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants