enhance(core): fast initialization (#186) - quickfix

tech-systems · Jun 24, 2023 · daa1eee · daa1eee
1 parent b36600b
commit daa1eee
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 41 deletions.
diff --git a/dist/core/index.js b/dist/core/index.js
diff --git a/dist/cupertino-pane.esm.js b/dist/cupertino-pane.esm.js
@@ -2090,7 +2090,6 @@ class CupertinoPane {
                 console.warn('Cupertino Pane: specified selector or DOM element already in use', this.selector);
                 return;
             }
-            console.time("Presenting time");
             // Emit event
             this.emit('onWillPresent');
             this.updateScreenHeights();
@@ -2101,9 +2100,6 @@ class CupertinoPane {
             // Custom transitions for present/destroy: set styles
             Object.assign(this.paneEl.style, (_a = conf === null || conf === void 0 ? void 0 : conf.transition) === null || _a === void 0 ? void 0 : _a.from);
             // Show elements
-            // For some reason need requestAnimationFrame after show wrapper to make 
-            // initial transition works
-            // TODO: resolve animation frame for transition on pane init
             this.wrapperEl.style.display = 'block';
             this.contentEl.style.display = 'block';
             this.wrapperEl.classList.add('rendered');
@@ -2143,7 +2139,6 @@ class CupertinoPane {
             this.emit('beforePresentTransition', { animate: conf.animate });
             // One frame before transition
             yield new Promise(resolve => requestAnimationFrame(resolve));
-            console.timeEnd("Presenting time");
             if (conf.animate) {
                 yield this.transitions.doTransition({
                     type: 'present', conf,
@@ -2178,12 +2173,11 @@ class CupertinoPane {
             this.overflowEl.style.overflowX = 'hidden';
         }
         this.overflowEl.style.overscrollBehavior = 'none';
-        if (this.settings.topperOverflow) {
-            if (this.settings.upperThanTop) {
-                console.warn('Cupertino Pane: "upperThanTop" allowed for disabled "topperOverflow"');
-            }
-            this.setOverflowHeight();
+        if (this.settings.topperOverflow
+            && this.settings.upperThanTop) {
+            console.warn('Cupertino Pane: "upperThanTop" allowed for disabled "topperOverflow"');
         }
+        this.setOverflowHeight();
     }
     setOverflowHeight(offset = 0) {
         this.overflowEl.style.height = `${this.getPaneHeight()

diff --git a/dist/cupertino-pane.esm.min.js b/dist/cupertino-pane.esm.min.js
diff --git a/dist/cupertino-pane.esm.min.js.map b/dist/cupertino-pane.esm.min.js.map
diff --git a/dist/cupertino-pane.js b/dist/cupertino-pane.js
diff --git a/dist/cupertino-pane.js.map b/dist/cupertino-pane.js.map
diff --git a/dist/cupertino-pane.min.js b/dist/cupertino-pane.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "cupertino-pane",
   "description": "New generation interfaces for web3 progressive applications",
-  "version": "1.3.3",
+  "version": "1.3.31",
   "author": "Roman Antonov (roman-rr)",
   "homepage": "https://github.com/roman-rr/cupertino-pane/",
   "repository": "roman-rr/cupertino-pane",

diff --git a/src/cupertino-pane.ts b/src/cupertino-pane.ts
@@ -266,8 +266,6 @@ export class CupertinoPane {
         return;
       }
 
-      console.time("Presenting time");
-
       // Emit event
       this.emit('onWillPresent');
 
@@ -282,9 +280,6 @@ export class CupertinoPane {
       Object.assign(this.paneEl.style, conf?.transition?.from);
 
       // Show elements
-      // For some reason need requestAnimationFrame after show wrapper to make 
-      // initial transition works
-      // TODO: resolve animation frame for transition on pane init
       this.wrapperEl.style.display = 'block';
       this.contentEl.style.display = 'block';
       this.wrapperEl.classList.add('rendered');
@@ -331,14 +326,10 @@ export class CupertinoPane {
 
       // System event
       this.emit('beforePresentTransition', {animate: conf.animate});
-
 
       // One frame before transition
       await new Promise(resolve => requestAnimationFrame(resolve));
 
-      console.timeEnd("Presenting time");
-
-
       if (conf.animate) {
         await this.transitions.doTransition({
           type: 'present', conf,
@@ -377,13 +368,12 @@ export class CupertinoPane {
     }
     this.overflowEl.style.overscrollBehavior = 'none';
 
-    if (this.settings.topperOverflow) {   
-      if (this.settings.upperThanTop) {
-        console.warn('Cupertino Pane: "upperThanTop" allowed for disabled "topperOverflow"');
-      }
-
-      this.setOverflowHeight();
+    if (this.settings.topperOverflow 
+        && this.settings.upperThanTop) {   
+      console.warn('Cupertino Pane: "upperThanTop" allowed for disabled "topperOverflow"');
     }
+
+    this.setOverflowHeight();
   }
 
   public setOverflowHeight(offset = 0) {