This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Revert removal of CommonJS build #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowiebenoot
requested review from
jelledc,
lorgan3,
KristofColpaert,
driesd,
qubis741,
eniskraasniqi1,
BeirlaenAaron and
JorenSaeyTL
eniskraasniqi1
approved these changes
Nov 30, 2023
farazatarodi
approved these changes
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We decided to revert the previous change of removing the CommonJS build because the ecosystem is not ready to only have an ESModules build. It's hard to get jest working when you just have an ESM build. So to keep things easy we decided to revert it and have both a CommonJS and ESModules build again.
Version 24 will be deprecated.
So between 23 and 25 there actually won't be a breaking change anymore.