This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
[FIX] Looping of menu item #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaandevylder
requested review from
qubis741,
KristofColpaert,
lowiebenoot,
BeirlaenAaron,
driesd,
eniskraasniqi1,
farazatarodi,
jelledc,
JorenSaeyTL and
lorgan3
lorgan3
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Q: Do we need to to anything to make sure to not undo this fix? #2267
@eniskraasniqi1 maybe you remember when the menu opened as an empty square?
qubis741
previously approved these changes
Dec 5, 2022
KristofColpaert
previously approved these changes
Dec 5, 2022
|
Not really 😅, but I'm going to test those changes locally (bring back some lines), and see if I added this line for a good reason. EDIT: Can't link UI locally, will try with someone tmr. |
jelledc
previously approved these changes
Dec 5, 2022
lowiebenoot
reviewed
Dec 6, 2022
|
@lowiebenoot The item should not be rerendered |
stefaandevylder
dismissed stale reviews from jelledc, KristofColpaert, and qubis741
via
75707b7
stefaandevylder
force-pushed
the
fix/looping-menu-item
branch
from
9765840
to
75707b7
Compare
qubis741
approved these changes
Dec 6, 2022
JorenSaeyTL
approved these changes
Dec 6, 2022
BeirlaenAaron
approved these changes
Dec 6, 2022
lowiebenoot
approved these changes
Dec 6, 2022
eniskraasniqi1
approved these changes
Dec 6, 2022
|
Group MCed with @eniskraasniqi1 and @stefaandevylder ✅ |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the possibility to have an infinite loop. This was introduced when converting from JS to Typescript. Bug was found with Sentry.
This is a shot in the dark, but most likely the fix.
Sentry: https://sentry.io/organizations/teamleader/issues/3788415931/?project=1211390&referrer=slack