This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Make sure Dialog scroll shadow appears above inner elements #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeirlaenAaron
requested review from
lowiebenoot,
jelledc,
lorgan3,
KristofColpaert,
driesd,
qubis741,
stefaandevylder,
eniskraasniqi1,
JorenSaeyTL and
farazatarodi
farazatarodi
approved these changes
Nov 23, 2022
qubis741
approved these changes
Nov 23, 2022
lowiebenoot
approved these changes
Nov 23, 2022
|
Aren't we supposed to bump version (in package.json and changelog) inside our PR now? |
It's optional, but preferred |
driesd
approved these changes
Nov 23, 2022
stefaandevylder
approved these changes
Nov 23, 2022
lowiebenoot
approved these changes
Nov 23, 2022
KristofColpaert
approved these changes
Nov 23, 2022
|
Manually checked ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The scroll shadow of dialogs wasn't appearing above inner elements like inputs
Just adding a z-index seems to fix this
This was a problem with elements in the dialog taking it's full width (f.e. DataGrid), the scroll shadow wouldn't be visible at all because it's under it
Screenshot before this PR
Screenshot after this PR
Breaking changes
N/A