Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Properly call onChange in DatePickerInput #2448

Merged
merged 19 commits into from
Nov 21, 2022
Merged

Properly call onChange in DatePickerInput #2448

merged 19 commits into from
Nov 21, 2022

Conversation

qubis741
Copy link
Contributor

@qubis741 qubis741 commented Nov 16, 2022 •
edited by eniskraasniqi1
Loading

Fixed

  • DatePickerInput: overall functionality

Notes:

  • properly call onChange in all cases (onPopover close, as previously it was called multiple times sometimes)
  • fixed displaying of passed error from props
  • if written date is not valid, string is passed in onChange which indicates in our codebase validations that date is not valid

Manuel Check

  • DatePicker story works
  • DatePickerInput story works
  • MC in core with UI library (this PR) connected

@qubis741
allow selectedDate to be controlled by prop
044f7e0
@qubis741
moved useEffect to top of component so its more visible
ab3aba0
@qubis741
give external error higher priority than internal
2ae4d3a
@qubis741
return string in onChange, if invalid date
30cb112
@qubis741
adapt tests to new type definition of onChange
b50ae46
@qubis741
call onChange on closing of popover, so proper argument is passed
72c371f
@qubis741
changed others.selectedDate to preselectedDate for easier readability
7736dff
@qubis741
added isValidDate util
b9770ba
@qubis741
improved DatePickerInput useEffect to properly assign preselectedDate…
aaa81ad 
… in different cases
@qubis741
added conditional typed argument to DatePickerInput onChange
70f176f
@qubis741
properly set date if preselectedDate is invalid
74f3a60
@qubis741
added isValid locale util
3f8d079
@qubis741
allow string type in selectedDate prop to match reality and adapt cod…
1ba7615 
…e accordingly
@qubis741
added comment to explain ts-ignore
d4847f9
@qubis741
Merge branch 'next-release' into FRAF-1154-v4
935b822
@qubis741
bump version
cb37d27
@qubis741 qubis741 marked this pull request as ready for review November 18, 2022 16:01
@qubis741 qubis741 self-assigned this Nov 18, 2022
eniskraasniqi1
eniskraasniqi1 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@eniskraasniqi1 eniskraasniqi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked storybook, looks ok ✅

@qubis741 qubis741 merged commit 7ec493d into next-release Nov 21, 2022
@qubis741 qubis741 deleted the FRAF-1154-v4 branch November 21, 2022 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eniskraasniqi1 eniskraasniqi1 eniskraasniqi1 approved these changes

@lorgan3 lorgan3 lorgan3 approved these changes

@jelledc jelledc jelledc approved these changes

@BeirlaenAaron BeirlaenAaron Awaiting requested review from BeirlaenAaron

@KristofColpaert KristofColpaert Awaiting requested review from KristofColpaert

@driesd driesd Awaiting requested review from driesd

@farazatarodi farazatarodi Awaiting requested review from farazatarodi farazatarodi is a code owner

@JorenSaeyTL JorenSaeyTL Awaiting requested review from JorenSaeyTL

@lowiebenoot lowiebenoot Awaiting requested review from lowiebenoot lowiebenoot is a code owner

@stefaandevylder stefaandevylder Awaiting requested review from stefaandevylder

Assignees

@qubis741 qubis741

Labels
bug ready release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qubis741 @jelledc @lorgan3 @eniskraasniqi1