This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Clean up general Storybook structure and docs pages #1894
Merged
ArnaudWeyts
merged 18 commits into
next-release
from
ATL-718-clean-up-documentation-pages
Jan 10, 2022
Merged
Clean up general Storybook structure and docs pages #1894
ArnaudWeyts
merged 18 commits into
next-release
from
ATL-718-clean-up-documentation-pages
Jan 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they don't belong in the component library
these globals are unused, and they are hindering storybook from supporting native .env files
we still want the canvas and docs tabs in development, in order to debug a component, but on production, we should just have one single page for a component
even though it's not really a component, we still want it on the same level as the icon
ArnaudWeyts
requested review from
lowiebenoot,
joaoinacio,
lorgan3,
qubis741,
sanderbrugge,
MathiasDL and
JorenSaeyTL
January 6, 2022 19:39
ArnaudWeyts
changed the title
[ATL-718] Clean up general Storybook structure and docs pages
Clean up general Storybook structure and docs pages
Jan 6, 2022
…g them inside of the map
lowiebenoot
approved these changes
Jan 7, 2022
lorgan3
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some great improvements!
sanderbrugge
approved these changes
Jan 7, 2022
From ticket:
|
@qubis741 Yep, zeroheight is indeed that link. It's the platform our design system uses to deploy the guidelines. About the typography guidelines, I've spent quite some time on trying to fix the inputs, but didn't manage to come to a solution. I noticed we have other components that are experiencing these issues as well, so I'll take it up in a separate ticket |
qubis741
approved these changes
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description