Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make conditional ui available via env var in quickstart #653

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

like-a-bause
Copy link
Contributor

Description

Adds the ability to set experimental feature conditional ui in quickstart

Implementation

Tests

Todos

Additional context

@bjoern-m
Copy link
Contributor

Just to be sure, is it intended that the value of HANKO_ENABLE_CONDITIONAL_UI is discarded? So when I set HANKO_ENABLE_CONDITIONAL_UI=false it's okay that conditional UI is enabled anyway, because it's just a "flag"?

@bjoern-m bjoern-m force-pushed the feat-config-conditional-ui branch from 29325f9 to fdf1099 Compare March 14, 2023 15:18
@like-a-bause
Copy link
Contributor Author

Just to be sure, is it intended that the value of HANKO_ENABLE_CONDITIONAL_UI is discarded? So when I set HANKO_ENABLE_CONDITIONAL_UI=false it's okay that conditional UI is enabled anyway, because it's just a "flag"?

Yes. I thought of it as a boolean flag. But I don't have a strong opinion about that. We could also handle this as "must explicitly be set to true".

@bjoern-m
Copy link
Contributor

Just to be sure, is it intended that the value of HANKO_ENABLE_CONDITIONAL_UI is discarded? So when I set HANKO_ENABLE_CONDITIONAL_UI=false it's okay that conditional UI is enabled anyway, because it's just a "flag"?

Yes. I thought of it as a boolean flag. But I don't have a strong opinion about that. We could also handle this as "must explicitly be set to true".

Ok, me neither, but I think we should create a task to mention the available environment variables in the quickstart README.

@like-a-bause like-a-bause merged commit 5cdae17 into main Mar 14, 2023
@like-a-bause like-a-bause deleted the feat-config-conditional-ui branch March 24, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants