Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selenium log suppression: forward both positional and keyword args #2667

Merged
merged 2 commits into from
May 10, 2023
Merged

selenium log suppression: forward both positional and keyword args #2667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf15917
selenium log suppression: forward both positional and keyword args
kyrofa May 8, 2023
caa796c
Update logger_suppressor.rb
twalpole May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/capybara/selenium/logger_suppressor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module Capybara
module Selenium
module DeprecationSuppressor
def initialize(*)
def initialize(...)
Copy link
Contributor Author

@kyrofa kyrofa May 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to point out that this is incompatible with Ruby 2.5, but then I took a closer look at the gemspec and saw the required_ruby_version 😛 . I'm sorry, I should have done it this way from the beginning. Thanks for covering for me.

@suppress_for_capybara = false
super
end
Expand Down Expand Up @@ -31,7 +31,7 @@ def suppress_deprecations
end

module ErrorSuppressor
def for_code(*)
def for_code(...)
::Selenium::WebDriver.logger.suppress_deprecations do
super
end
Expand Down