feat: allow to set a custom bit roots directory #9053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiladShoham
reviewed
Jul 23, 2024
| const relativePath = this.dependencyResolver.getRuntimeModulePath(component); | ||
| const relativePath = this.dependencyResolver.getRuntimeModulePath(component, { | ||
| workspacePath: this.workspace.path, | ||
| rootComponentsPath: this.workspace.rootComponentsPath, |
There was a problem hiding this comment.
don't you need the isInWorkspace prop here?
There was a problem hiding this comment.
I guess I don't need it as it wasn't here before my changes.
GiladShoham
reviewed
Jul 23, 2024
| * Get the location of the bit roots folder | ||
| */ | ||
| get rootComponentsPath() { | ||
| return path.join(this.config.rootComponentsDirectory ?? this.modulesPath, BIT_ROOTS_DIR); |
There was a problem hiding this comment.
something looks missing to me here
in case it was configured you don't have the workspace path.
if it's not configured you will have
/path-to-workspace/node_modules/.bit_roots
if it's configured, you will have
/configured-path/.bit_roots
without the workspace path in the beginning
GiladShoham
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes