-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to set a custom bit roots directory #9053
feat: allow to set a custom bit roots directory #9053
Conversation
const relativePath = this.dependencyResolver.getRuntimeModulePath(component); | ||
const relativePath = this.dependencyResolver.getRuntimeModulePath(component, { | ||
workspacePath: this.workspace.path, | ||
rootComponentsPath: this.workspace.rootComponentsPath, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you need the isInWorkspace
prop here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I don't need it as it wasn't here before my changes.
* Get the location of the bit roots folder | ||
*/ | ||
get rootComponentsPath() { | ||
return path.join(this.config.rootComponentsDirectory ?? this.modulesPath, BIT_ROOTS_DIR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something looks missing to me here
in case it was configured you don't have the workspace path.
if it's not configured you will have
/path-to-workspace/node_modules/.bit_roots
if it's configured, you will have
/configured-path/.bit_roots
without the workspace path in the beginning
Proposed Changes