Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use aspect manifest to determine which dependencies are aspects instead importing and loading them #8738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidfirst
Copy link
Member

Currently, we load (and import if not exist) each one of the aspect dependencies in order to check if it's an aspect.
To improve the performance and to not bring unnecessary components, this PR finds and reads the manifest to see which dependencies were injected.


const { manifests } = await this.loadAspectDefsByOrder(aspectsDefs, [component.id.toString()], true, true);
const manifest = manifests[0];
const runtimeDeps = manifest.getRuntime(MainRuntime)?.dependencies?.map((dep) => dep.id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you assume it's the main runtime here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants