Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sessionprojector): fix broken scale factor / screen size calculation #19

Merged
merged 5 commits into from
Jun 28, 2023
Merged

fix(sessionprojector): fix broken scale factor / screen size calculation #19

merged 5 commits into from
Jun 28, 2023

Conversation

unstabler
Copy link
Collaborator

DESCRIPTION

  • This PR resolves mouse cursor position issues with HiDPI (Retina) displays #13.
    • fixed broken scale factor calculation when posting mouse move events.
    • fixed broken scale factor / screen size calculation which causes screen freezing
      • each implementation of ScreenRecorder now passes pre-scaled rects to ScreenUpdateSubscriber.

@unstabler unstabler changed the title fix(sessionprojector): fix(sessionprojector): fix broken scale factor / screen size calculation Jun 28, 2023
@unstabler unstabler merged commit 49ce1a4 into main Jun 28, 2023
@unstabler unstabler deleted the fix/sessionprojector-hidpi branch June 28, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mouse cursor position issues with HiDPI (Retina) displays
1 participant
@unstabler