Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”¨ fix(member): νšŒμ›κ°€μž… κ΄€λ ¨ 둜직 λ³€κ²½ #67

Merged
merged 3 commits into from
Nov 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 60 additions & 53 deletions src/main/java/com/tikitaka/naechinso/domain/TestController.java

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public CommonApiResponse<MemberLoginResponseDTO> forceLogin(

@PostMapping("/reissue")
@ApiOperation(value = "λ¦¬ν”„λ ˆμ‹œ 토큰을 톡해 μƒˆλ‘œμš΄ 토큰을 λ°œκΈ‰λ°›λŠ”λ‹€ (RefreshToken)")
public CommonApiResponse<TokenResponseDTO> reissue(
public CommonApiResponse<MemberReissueResponseDTO> reissue(
@RequestHeader("Authorization") String accessToken,
@RequestHeader("Refresh") String refreshToken
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
import com.tikitaka.naechinso.domain.pending.constant.PendingType;
import com.tikitaka.naechinso.domain.pending.dto.PendingFindResponseDTO;
import com.tikitaka.naechinso.domain.pending.dto.PendingUpdateMemberImageRequestDTO;
import com.tikitaka.naechinso.domain.recommend.RecommendRepository;
import com.tikitaka.naechinso.domain.recommend.dto.RecommendReceiverDTO;
import com.tikitaka.naechinso.domain.recommend.entity.Recommend;
import com.tikitaka.naechinso.global.common.request.TokenRequestDTO;
import com.tikitaka.naechinso.global.common.response.TokenResponseDTO;
Expand All @@ -34,6 +36,7 @@
public class MemberService {
private final JwtTokenProvider jwtTokenProvider;
private final PendingService pendingService;
private final RecommendRepository recommendRepository;
private final MemberRepository memberRepository;
private final MemberDetailRepository memberDetailRepository;

Expand Down Expand Up @@ -91,7 +94,7 @@ public MemberLoginResponseDTO logout(Member authMember) {
* 둜그인 -> Fcm Token DB에 λ“±λ‘ν•œλ‹€
* @// TODO: 2022/10/30 λ…Έμ…˜μ— 정리
* */
public TokenResponseDTO reissue(String accessToken, String refreshToken) {
public MemberReissueResponseDTO reissue(String accessToken, String refreshToken) {
String phone;

if (!jwtTokenProvider.validateTokenExceptExpiration(accessToken)){
Expand All @@ -105,8 +108,33 @@ public TokenResponseDTO reissue(String accessToken, String refreshToken) {
}

Member authMember = findByPhone(phone);

//κ°€μž… μ—¬λΆ€ (detail == null) 확인 ν›„ 받은 μΆ”μ²œμ„œ κΊΌλ‚΄μ˜΄
final Boolean hasDetail = authMember.getDetail() != null;

//λ§Œμ•½ μ •νšŒμ›μ΄ μ•„λ‹ˆλΌλ©΄ 받은 μΆ”μ²œ λͺ©λ‘μ„ κ°€μ Έμ˜΄
List<RecommendReceiverDTO> recommendReceived;
if (!hasDetail) {
recommendReceived = recommendRepository.findAllByReceiverPhoneAndSenderNotNull(phone)
.stream().map(RecommendReceiverDTO::of).collect(Collectors.toList());
} else {
recommendReceived = null;
}

//μœ μ € λ°΄ μ—¬λΆ€ κ°€μ Έμ˜€κΈ°
final Boolean isBanned = false;

jwtTokenProvider.validateRefreshToken(phone, refreshToken);
return jwtTokenProvider.generateToken(new JwtDTO(phone, authMember.getRole().toString()));

TokenResponseDTO tokenResponseDTO = jwtTokenProvider.generateToken(new JwtDTO(phone, authMember.getRole().toString()));

return MemberReissueResponseDTO.builder()
.accessToken(tokenResponseDTO.getAccessToken())
.refreshToken(tokenResponseDTO.getRefreshToken())
.recommendReceived(recommendReceived)
.isActive(hasDetail)
.isBanned(isBanned)
.build();
}


Expand Down Expand Up @@ -145,6 +173,11 @@ public MemberDetailResponseDTO readDetail(Member member) {
return MemberDetailResponseDTO.of(member);
}


/**
* μΆ”μ²œμ‚¬λ₯Ό 받은 μœ μ €μ˜ μ„ΈλΆ€ νšŒμ› κ°€μž…
* @// TODO: 2022/11/05 κΈ°λ³Έ 정보도 μΆ”κ°€λ‘œ μˆ˜μ •
**/
public MemberDetailResponseDTO createDetail(Member authMember, MemberDetailJoinRequestDTO dto) {
//μ˜μ†μ„± μœ μ§€λ₯Ό μœ„ν•œ fetch
Member member = findByMember(authMember);
Expand All @@ -167,6 +200,9 @@ public MemberDetailResponseDTO createDetail(Member authMember, MemberDetailJoinR

//받은 μΆ”μ²œμ‚¬ 쀑 ν•œλͺ…이라도 인증이 μ™„λ£Œλœ μƒνƒœλ©΄ μ •νšŒμ› κ°€μž… μ‹€ν–‰
if (recommend.getSender().getJobAccepted() || recommend.getSender().getEduAccepted()) {
member.updateCommonInfo(dto);
memberRepository.save(member);

MemberDetail detail = MemberDetail.of(member, dto);
memberDetailRepository.save(detail);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public class MemberCommonJoinRequestDTO {
@Enum(enumClass = Gender.class, message = "성별 μž…λ ₯이 μ˜¬λ°”λ₯΄μ§€ μ•ŠμŠ΅λ‹ˆλ‹€. M λ˜λŠ” Wκ°€ ν•„μš”ν•©λ‹ˆλ‹€")
private Gender gender;

@ApiModelProperty(example = "25")
@Min(value = 25, message = "25-35μ„ΈκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@Max(value = 35, message = "25-35μ„ΈκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@ApiModelProperty(example = "1998")
@Min(value = 1988, message = "1988-1998 λ…„μƒκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@Max(value = 1998, message = "1988-1998 λ…„μƒκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
private int age;

@NotNull(message = "μ„œλΉ„μŠ€ μ΄μš©μ•½κ΄€ λ™μ˜κ°€ ν•„μš”ν•©λ‹ˆλ‹€")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ public class MemberDetailJoinRequestDTO {
@Enum(enumClass = Gender.class, message = "성별 μž…λ ₯이 μ˜¬λ°”λ₯΄μ§€ μ•ŠμŠ΅λ‹ˆλ‹€. M λ˜λŠ” Wκ°€ ν•„μš”ν•©λ‹ˆλ‹€")
private Gender gender;

@ApiModelProperty(example = "25")
@Min(value = 25, message = "25-35μ„ΈκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@Max(value = 35, message = "25-35μ„ΈκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@ApiModelProperty(example = "1998")
@Min(value = 1988, message = "1988-1998 λ…„μƒκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@Max(value = 1998, message = "1988-1998 λ…„μƒκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
private int age;

@ApiModelProperty(example = "180")
Expand All @@ -57,10 +57,6 @@ public class MemberDetailJoinRequestDTO {
@Length(max = 4, message = "μ˜¬λ°”λ₯Έ MBTI 정보λ₯Ό μž…λ ₯ν•˜μ„Έμš”")
private String mbti;

// @ApiModelProperty(example = "직관적")
// @NotBlank(message = "성격 정보λ₯Ό μž…λ ₯ν•΄μ•Ό ν•©λ‹ˆλ‹€")
// private String personality;

@ApiModelProperty(example = "[\"열정적인 \uD83D\uDD25\", \"지적인 \uD83E\uDDD0\", \"상λƒ₯ν•œ ☺️\"]")
@Size(min = 3, max = 3, message = "성격 ν‚€μ›Œλ“œ 3개λ₯Ό μž…λ ₯ν•΄μ•Ό ν•©λ‹ˆλ‹€")
@NotNull
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package com.tikitaka.naechinso.domain.member.dto;

import com.fasterxml.jackson.annotation.JsonInclude;
import com.tikitaka.naechinso.domain.recommend.dto.RecommendReceiverDTO;
import lombok.*;

import java.util.ArrayList;
import java.util.List;

/**
* 토큰 μž¬λ°œκΈ‰μ„ λ‹΄λ‹Ήν•˜λŠ” 응닡 DTO
* */
@AllArgsConstructor
@NoArgsConstructor
@Getter
@Builder
@ToString
@JsonInclude(JsonInclude.Include.NON_NULL) //NULL ν•„λ“œ κ°€λ¦Ό
public class MemberReissueResponseDTO {
private String accessToken;
private String refreshToken;

//λ‚΄ 번호둜 μΆ”μ²œλ°›μ€ 정보 리슀트
private List<RecommendReceiverDTO> recommendReceived;
//κ°€μž… μ™„λ£Œν–ˆλŠ”μ§€ μ—¬λΆ€, detail 정보가 있으면 true
private Boolean isActive = false;
//μ„œλ²„λ‘œλΆ€ν„° 차단 λ‹Ήν–ˆλŠ”μ§€ μ—¬λΆ€
private Boolean isBanned = false;
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ public class MemberUpdateCommonRequestDTO {
@Enum(enumClass = Gender.class, message = "성별 μž…λ ₯이 μ˜¬λ°”λ₯΄μ§€ μ•ŠμŠ΅λ‹ˆλ‹€. M λ˜λŠ” Wκ°€ ν•„μš”ν•©λ‹ˆλ‹€")
private Gender gender;

@ApiModelProperty(example = "25")
@Min(value = 25, message = "25-35μ„ΈκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@Max(value = 35, message = "25-35μ„ΈκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@ApiModelProperty(example = "1998")
@Min(value = 1988, message = "1988-1998 λ…„μƒκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
@Max(value = 1998, message = "1988-1998 λ…„μƒκΉŒμ§€λ§Œ κ°€μž… κ°€λŠ₯ν•©λ‹ˆλ‹€")
private int age;
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
import com.tikitaka.naechinso.domain.match.entity.Match;
import com.tikitaka.naechinso.domain.member.constant.Gender;
import com.tikitaka.naechinso.domain.member.constant.Role;
import com.tikitaka.naechinso.domain.member.dto.MemberUpdateAcceptsRequestDTO;
import com.tikitaka.naechinso.domain.member.dto.MemberUpdateCommonRequestDTO;
import com.tikitaka.naechinso.domain.member.dto.MemberUpdateEduRequestDTO;
import com.tikitaka.naechinso.domain.member.dto.MemberUpdateJobRequestDTO;
import com.tikitaka.naechinso.domain.member.dto.*;
import com.tikitaka.naechinso.domain.pending.entity.Pending;
import com.tikitaka.naechinso.domain.point.constant.PointType;
import com.tikitaka.naechinso.domain.point.entity.Point;
Expand Down Expand Up @@ -202,6 +199,12 @@ public void setDetail(MemberDetail memberDetail) {
this.detail = memberDetail;
}

public void updateCommonInfo(MemberDetailJoinRequestDTO requestDTO) {
this.name = requestDTO.getName();
this.age = requestDTO.getAge();
this.gender = requestDTO.getGender();
}

public void updateAccepts(MemberUpdateAcceptsRequestDTO requestDTO) {
this.acceptsMarketing = requestDTO.isAcceptsMarketing();
this.acceptsPush = requestDTO.isAcceptsPush();
Expand Down