Fix hyperlinks in excel #838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Write hyperlinks after sheetData, as excel can't read them if they come before sheetData - Don't add hyperlink with Location to relations. Location is used to store links to locations within the same xlsx file and must not have a linked external relation - Add support for hyperlink location to diskv CellStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elements inside a worksheet are defined as a sequence, meaning excel expects the elements in a specific order.
Hyperlinks currently are written before sheetData, but must come after sheetData, otherwise it will fail to read them.
Also internal links need to be stored in
location, which currently get's lost during save.This fixes #836. Also it adds support for handling internal links in Excel-readable way.