Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.7.0 #369

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Prepare release 1.7.0 #369

merged 1 commit into from
Oct 2, 2024

Conversation

dbrgn
Copy link
Collaborator

@dbrgn dbrgn commented Jun 17, 2024

Did we forget anything?

Things that need to be done before the release:

...anything else?

@dbrgn dbrgn requested a review from niklasmohrin June 17, 2024 00:18
@dbrgn dbrgn self-assigned this Jun 17, 2024
@niklasmohrin
Copy link
Collaborator

Yes I am still waiting for you in #345 (comment) and would like to include that in the release

@dbrgn
Copy link
Collaborator Author

dbrgn commented Jul 21, 2024

@niklasmohrin can you check your Matrix messages?

@dbrgn dbrgn mentioned this pull request Aug 12, 2024
@dbrgn
Copy link
Collaborator Author

dbrgn commented Aug 15, 2024

@niklasmohrin sorry for bothering you again over this channel, but I sent you another message 🙂

@niklasmohrin
Copy link
Collaborator

Hmmmm, apparently I have something misconfigured over there 🤔 :D

@dbrgn dbrgn marked this pull request as ready for review October 2, 2024 19:22
@dbrgn dbrgn changed the title Draft: Prepare CHANGELOG for release 1.7.0 Prepare release 1.7.0 Oct 2, 2024
@dbrgn dbrgn force-pushed the release-1.7.0 branch 5 times, most recently from 885e035 to 02e70a0 Compare October 2, 2024 19:36
@@ -7,16 +7,13 @@ Run linting:
Set variables:

$ export VERSION=X.Y.Z
$ export GPG_KEY=EA456E8BAF0109429583EED83578F667F2F3A5FA
$ export GPG_KEY=20EE002D778AE197EF7D0D2CB993FF98A90C9AB1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niklasmohrin if you have a GPG signing key, you can replace this with your own key ID after the release.

@dbrgn dbrgn requested review from niklasmohrin and removed request for niklasmohrin October 2, 2024 19:38
@dbrgn
Copy link
Collaborator Author

dbrgn commented Oct 2, 2024

@niklasmohrin I believe this is now ready. Could you check if everything looks good to you? Once that's done, I'll publish the release 🙂

@niklasmohrin
Copy link
Collaborator

Do we want to change the default features to ["native-tls"], or leave that for the next release?

@dbrgn
Copy link
Collaborator Author

dbrgn commented Oct 2, 2024

Given that it's no urgent issue without workaround, and since it only affects people in networks that do active TLS interception, I think we can move that to the next release.

@niklasmohrin
Copy link
Collaborator

Alright then, I will aim for the next release to be earlier than two years anyways :D

@dbrgn
Copy link
Collaborator Author

dbrgn commented Oct 2, 2024

@niklasmohrin rebased after merging the dependency updates!

@dbrgn dbrgn merged commit d44613c into main Oct 2, 2024
9 checks passed
@dbrgn dbrgn deleted the release-1.7.0 branch October 2, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants