-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(1) cmd tool (watch) does NOT work for template (2) does NOT work for all formats when using vscode editor #372
Comments
Thanks for the elaborate bug report. Looks like the watch functionality needs some work. However, to address two concerns: 1) minifying templates is not really supported, though even so the watch functionality should work. I will look into this. 4) some IDEs work differently with saving files which may affect the watch function. I should install vscode and see how it saves files. This will take some time to fix, thanks again for the report! |
…e set, fix watch when src is not a dir; see #372
Fixed a bunch of bugs in the watch functionality, please check if it's working well for you (the points you addressed should all be fixed now). Feedback appreciated ;-) |
Some backgrounds
Sorry that I did a lot of editing after opening this issue. Now, after I understand the problem even more clear, I will try to reformat the question again. I hope my words make sense. Thank you very much for your project and help.
There are actually 4 problems. I am not sure if I should open 4 issues or just single one. I will try to describe 4 problems here for now.
I am running Linux OS (MX Linux based on debian 10).
I installed the latest minify cmd tool from the git clone source at the time I am posting this issue.
Values of my variables:
$CSS_SRC_PATH is web/src/css/
$CSS_DST_PATH is web/dist/css/
$TMPL_SRC_PATH is web/src/template/
$TMPL_DST_PATH is web/dist/template/
(1) cmd tool watch feature does NOT work for template
The above command does NOT work at all. There is no minifying happened.
Then I tried the following cml:
The above command only minifies files once. The -w watching does NOT work at all. After I change something in the src tempate, there is no further minifying update.
(2) cmd tool watch does NOT work for all formats when the src is not a directory
From the README.md, it should work when src is not a directory, but it doesn't work.
The above -w watch command does NOT work. No watch update at all.
The above -w watch command does NOT work. No watch update at all.
(3) cmd tool watch does NOT work when target/destination is not a directory
From README.md, the example shows I can use non directory destination with watch.
The above command does NOT work at all. Error msg:
ERROR: --watch requires destination to be a directory
.If destination can not be a non-directory, I can not give a different destination filename when using minify+watch.
(4) cmd tool watch does NOT work for all formats when using vscode editor
When I use
vscode
editor and opened both src and dst files. After I update src css file, the target file becomes an empty file most of times.When I use some simple editor such as
vim
orkwrite
, the watch update works as expected.I have no ideas what's going on with rich editors (or IDEs). I don't have auto-save turned on in vscode editor.
I did save only once after the modification update. But magically, the target file will become empty.
I never meet such problem with other watching update tools such as gulp watch tools etc...
Thank you very much for your time.
The text was updated successfully, but these errors were encountered: