Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Request.Configuration properties not being applied #47

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Some Request.Configuration properties not being applied #47

merged 2 commits into from
Jan 25, 2024

Conversation

tdeleon
Copy link
Owner

@tdeleon tdeleon commented Jan 25, 2024

The allowsConstrainedNetworkAccess and allowsExpensiveNetworkAccess were not being set on the generated urlRequest property on a Request.

This is only an issue when using Foundation (Apple platforms) and not FoundationNetworking (non-Apple platforms), as the properties only exist in the Foundation implementation of URLRequest.

@tdeleon tdeleon added this to the 2.1.4 milestone Jan 25, 2024
@tdeleon tdeleon added the bug Something isn't working label Jan 25, 2024
@tdeleon tdeleon linked an issue Jan 25, 2024 that may be closed by this pull request
Some Configuration properties not being set on Request.urlRequest #46
Closed
@tdeleon tdeleon merged commit 4b0c498 into develop Jan 25, 2024
11 checks passed
@tdeleon tdeleon deleted the 46-configuration-properties-not-set branch January 25, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

Some Configuration properties not being set on Request.urlRequest
1 participant
@tdeleon