Add splitio-adapter package

[tdeekens]

Thanks for @Kerumen we will soon have an adapter for splitio. This branch aims to fix the last issues with build setup, documentation etc.

[tdeekens]

This is the build error I was expecting. I will dive into another round of rollup debugging another day.

[tdeekens]

Couldn't resist. Debugging the plugin chain of rollup this comes from the babel-plugin which receives something like

import '../../modules/es6.string.iterator';
import '../../modules/es6.array.from';
import '../../modules/_core';
import 'commonjs-proxy:../../modules/es6.string.iterator';
import 'commonjs-proxy:../../modules/es6.array.from';
import require$$2 from 'commonjs-proxy:../../modules/_core';

which looks like the commonjs-plugin processes the core-js dependencies which it maybe shouldn't but it also shouldn't cause a problem. Unsure what a fix should or could be.

[codecov]

Codecov Report

Merging #67 into master will increase coverage by 0.63%.
The diff coverage is 98.11%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage    95.4%   96.03%   +0.63%     
==========================================
  Files          23       24       +1     
  Lines         174      227      +53     
  Branches       20       25       +5     
==========================================
+ Hits          166      218      +52     
- Misses          8        9       +1

Impacted Files	Coverage Δ
...ackages/splitio-adapter/modules/adapter/adapter.js	98.11% <98.11%> (ø)

[tdeekens]

I literally am baffled. There is a modulesOnly: true option for the plugin-resolve in rollup which does some funky things. Which stems from this issue and is exactly what we ran into. I am not even fully sure what it implies after reading the description five times. It seems like imports from a non ES module to an ES module without a pkg.main cause trouble at times to be detected correctly.

[tdeekens]

I will rebase one last time removing the replacing of the version from the package but rather reading it using the json-plugin.

[tdeekens]

Is there anything you see missing @Kerumen? Otherwise I'd be pretty confident to release this as 1.0.0 unless you want to test the code for instance again.

[Kerumen]

@tdeekens No I'm fine, go release this! Thanks for giving your time to investigate. The library just got better!

[tdeekens]

Sure. Let me know if you see any other areas or room for improvement. Always eager to hear other people's perspectives.

[tdeekens]

Voila. Let me know if there are problems.

https://github.com/tdeekens/flopflip/releases/tag/%40flopflip%2Fsplitio-adapter%401.0.0