Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update typings #531

Merged
merged 1 commit into from
Dec 3, 2018
Merged

update typings #531

merged 1 commit into from
Dec 3, 2018

Conversation

ChrisW-B
Copy link
Contributor

@ChrisW-B ChrisW-B commented Dec 3, 2018 •
edited
Loading

Summary

Updates some typings that cause build errors on tsc in Typescript v3.2.1

Description

tdeekens
tdeekens approved these changes Dec 3, 2018
View reviewed changes
Copy link
Owner

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. It's so cool when a side-project receives a PR by somebody seemingly using it :)

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #531 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          37       37           
  Lines         402      402           
  Branches       71       71           
=======================================
  Hits          381      381           
  Misses         20       20           
  Partials        1        1

@tdeekens tdeekens merged commit 4bf1e00 into tdeekens:master Dec 3, 2018
@ChrisW-B ChrisW-B deleted the chrisw_b/update-types branch December 3, 2018 16:56
@tdeekens
Copy link
Owner

tdeekens commented Dec 4, 2018

Released https://github.com/tdeekens/flopflip/releases/tag/%40flopflip%2Freact-broadcast%407.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisW-B @tdeekens