Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): read ELEMENT_TYPE_VAR signature type #41

Merged
merged 4 commits into from
Jun 25, 2022
Merged

Conversation

tdakkota
Copy link
Owner

@tdakkota tdakkota commented Jun 25, 2022

Fixes #36.

@tdakkota tdakkota marked this pull request as ready for review June 25, 2022 14:19
@codecov-commenter
Copy link

Codecov Report

Merging #41 (dbaaefd) into master (d92f9ee) will increase coverage by 0.53%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   20.32%   20.86%   +0.53%     
==========================================
  Files          19       19              
  Lines        3163     3182      +19     
==========================================
+ Hits          643      664      +21     
+ Misses       2439     2435       -4     
- Partials       81       83       +2     
Impacted Files Coverage Δ
cmd/printsig/find.go 0.00% <ø> (ø)
cmd/printsig/main.go 0.00% <0.00%> (ø)
types/element_type.go 25.00% <ø> (ø)
types/signature.go 53.48% <54.83%> (+4.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92f9ee...dbaaefd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signature reader does not return error when it fails
2 participants