Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change methods GetAmount... to GetNumber... #39

Closed
Roald87 opened this issue Jul 31, 2019 · 2 comments
Closed

Change methods GetAmount... to GetNumber... #39

Roald87 opened this issue Jul 31, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Roald87
Copy link
Contributor

Roald87 commented Jul 31, 2019

Before you freeze the API method names it might be good to change the method names which start with GetAmount... to GetNumber.... From the Cambridge dictionary:

We use amount of with uncountable nouns. Number of is used with countable nouns:

So GetAmountOfFailedTests then becomes GetNumberOfFailedTests.
@sagatowski
Copy link
Member

Excellent suggestion, thank you for this great feedback! Will be implemented in next release.

@sagatowski sagatowski added the enhancement New feature or request label Jul 31, 2019
sagatowski added a commit that referenced this issue Jul 31, 2019
@sagatowski
Solved issue #39 "Change methods GetAmount... to GetNumber..."
6387ca3 
Updated .gitignore-file to newest template.
@sagatowski
Copy link
Member

Solved in commit 6387ca3.

Roald87 added a commit to Roald87/TcUnit that referenced this issue Sep 30, 2020
@Roald87
Changed amount to number. See also tcunit#39.
14de3a9
sagatowski added a commit that referenced this issue Oct 2, 2020
@sagatowski
Merge pull request #122 from Roald87/master
ab9a705 
Changed amount to number. See also #39.
@Roald87 Roald87 mentioned this issue Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Roald87 @sagatowski