Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GVL_Constants #19

Closed
sagatowski opened this issue Jan 25, 2019 · 1 comment
Closed

Rename GVL_Constants #19

sagatowski opened this issue Jan 25, 2019 · 1 comment
Assignees
@sagatowski
Labels
enhancement New feature or request

Comments

@sagatowski
Copy link
Member

If you have a project that is using TcUnit and that is using the TE1200 static code analysis tool from Beckhoff, it will issue an warning "SA0027: Object name 'GVL_Constants' already used in Library 'tcunit, 0.4.1.0 (www.tcunit.org)'".
GVL_Constants is quite a common name to use for the constant GVLs, so it would be better if the constant-gvl would be renamed to something like GVL_Constants_TcUnit, so no name crashes occur.
@sagatowski sagatowski added the enhancement New feature or request label Jan 25, 2019
@sagatowski sagatowski self-assigned this Jan 25, 2019
sagatowski added a commit that referenced this issue Jun 15, 2019
@sagatowski
Solved the following issues:
7b31d90 
- issue #23 - Usage of FB_ADSAssertMessageFormatter.LogAssertFailure should warn
- issue #21 - Remove unused code
- issue #19 - Rename GVL_Constants
@sagatowski
Copy link
Member Author

Solved in commit 7b31d90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagatowski sagatowski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sagatowski