Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportResult in FB_AssertResultStatic should take expected/actual value into consideration #17

Closed
sagatowski opened this issue Dec 18, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sagatowski
Copy link
Member

The current solution of reporting asserts is not bullet-proof. Although the code says it checks for the complete combination of:

  • Test message
  • Test instance path
  • Expected value
  • Actual value
    It actually only checks for the first instance of test message/test instance path AND THEN checks if the expected value and actual value are according to the result as well. What the reporting should do is to check if the combination of all four exist.

For arrays it needs to be done differently. Here we need to replace the expected & actual value with the size of both arrays and the types of both arrays.

Question: Is it possible to add a identifier to every assert? If we assume that every assert is called at every cycle, we can create an index for every assert in every test suite.

@sagatowski sagatowski self-assigned this Dec 18, 2018
@sagatowski sagatowski added the enhancement New feature or request label Dec 18, 2018
@sagatowski sagatowski added this to the Christmas milestone milestone Dec 20, 2018
sagatowski added a commit that referenced this issue Dec 22, 2018
… expected/actual value into consideration"
@sagatowski
Copy link
Member Author

Solved with commit 00ffe42.

KubaO pushed a commit to Bertec/TcUnit that referenced this issue Dec 9, 2019
Issue tcunit#15 - "The verifier wastes quite a bit of time"
Issue tcunit#17 - "There's no need to add any attributes to test suites"
PR tcunit#16 - "Feature/speed up"
Issue tcunit#18 - "Discrepancy between 4022 and 4024 in TIME_TO_STRING makes tests fail"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant