Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore relative/local links? #10

Closed
hugovk opened this issue Oct 12, 2016 · 4 comments
Closed

Ignore relative/local links? #10

hugovk opened this issue Oct 12, 2016 · 4 comments

Comments

@hugovk
Copy link

hugovk commented Oct 12, 2016

Would it make sense to ignore relative and local links? And perhaps bitcoin links too?

[✖] /bots/
[✖] #past-sponsors
[✖] #page-content
[✓] https://twitter.com/algorithm_club
[✖] /resources/libraries-frameworks/#language
[✖] bitcoin:18WDyJFShLcLVCRyiEm3MijbCsBjcxG4mH?amount=0.025&label=Botwiki
@chrispomeroyhale
Copy link

While relative link support was added via issue #2, it wasn't working with local files. I wonder if this was what you are running into. I personally want relative links to be checked.

@tcort
Copy link
Owner

tcort commented Nov 20, 2016

There are a few issues here and they're are all sort of related... relative links, local relative links, links with different schemes (e.g. bitcoin:) and hash links (e.g. #page-content). I've got some ideas, which I wrote on pull request #13, that I'll implement.

Repository owner deleted a comment from PeterDaveHello Oct 9, 2017
PeterDaveHello added a commit to PeterDaveHello/nvm that referenced this issue Nov 4, 2017
@PeterDaveHello
[Docs] Use absolute URL for nvm-sh#606 in README.md
b76c5ea 
Since markdown-link-check hasn't support relative links, to make the
test passed, move this link to use absolute URL so that we can introduce
the new test. cc tcort/markdown-link-check#10
@PeterDaveHello PeterDaveHello mentioned this issue Nov 4, 2017
Merged
@dialex
Copy link
Contributor

dialex commented Dec 30, 2017 •
edited
Loading

I have the exact same problem. I tried the feature implemented in #13 but that didn't work for me. I need a command that works both locally and on CI (Travis). It needs to check recursively all md files inside a folder.

Here's my project's repo for reference. How can I do that?

@dialex dialex mentioned this issue Dec 30, 2017
Closed
@timmkrause timmkrause mentioned this issue May 18, 2018
Merged
@timmkrause
Copy link

Is this solved by #41 / with version 3.5.0?

ljharb pushed a commit to PeterDaveHello/nvm that referenced this issue Sep 29, 2021
@PeterDaveHello @ljharb
[Docs] Use absolute URL for nvm-sh#606 in README.md
7b530ed 
Since markdown-link-check hasn't support relative links, to make the
test passed, move this link to use absolute URL so that we can introduce
the new test. cc tcort/markdown-link-check#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chrispomeroyhale @tcort @hugovk @dialex @timmkrause @NicolasMassart