Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(join-lint): handle left anti join #607

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

clenost
Copy link
Contributor

@clenost clenost commented Jul 9, 2024

Hey 👋 A small addition to the current formatter (thanks for the work done there 👌 ).

Main idea is to handle better left anti joins that are defined within databricks

before

select
...
from table_a left
anti join table_b using(key)

after

select
...
from table_a
left anti join table_b using(key)

Feel free to tell me if you want me to modify the content of this PR 🙏

Copy link
Owner

@tconbeer tconbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! Could you please just add a Changelog entry?

@clenost clenost requested a review from tconbeer July 9, 2024 15:55
@tconbeer tconbeer merged commit 77cce99 into tconbeer:main Jul 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants