Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add indoor climbing and bouldering climbing activities #259

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

fedeizzo
Copy link

@fedeizzo fedeizzo commented Jan 13, 2025

What does this PR do?

Fit original PR to introduce the split type and parse correctly the fit file generated from climbing activities.

Sorry for the LOOOONG time between this and PR mentioned above 😅

This PR adds the support for two climbing activities: indoor climbing and buoldering.

⚠️ There is another PR that fixes a wrong message field name (min to avg), for more info check the second commit of this PR.

Testing

Indoor climbing on garming connect website
image

The db after parsing the file
image

Bouldering on garmin connect website
image

The db after parsing the file
image

@fedeizzo fedeizzo marked this pull request as ready for review January 13, 2025 18:06
@fedeizzo
Copy link
Author

Do I have to update the Fit dependency in this PR after I merge the other one?

@tcgoetz tcgoetz merged commit bf9a1b4 into tcgoetz:develop Jan 19, 2025
@tcgoetz
Copy link
Owner

tcgoetz commented Jan 19, 2025

Please test the develop branch and let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants