Feat/cartesian power and map #163
Conversation
…and power to cartesian_base file
…c... functions cartesian_product_with does not use the cartesian_default_read_traits as read_at behaviour is special for it.
…um selectors for product/power and tuple/map
Co-authored-by: Tristan Brindle <t.c.brindle@gmail.com>
Co-authored-by: Tristan Brindle <t.c.brindle@gmail.com>
Co-authored-by: Tristan Brindle <t.c.brindle@gmail.com>
Co-authored-by: Tristan Brindle <t.c.brindle@gmail.com>
Co-authored-by: Tristan Brindle <t.c.brindle@gmail.com>
…isaacy2012/flux into feat/cartesian-product-and-with
…epeat and cartesian_product_repeat_map
…roduct_repeat and cartesian_product_repeat_map" This reverts commit 1902bb8.
|
Hi @isaacy2012, it looks like this PR is using the "repeat" names, did you intend to change them back to "power"? :) |
Oops sorry, forgot to push the revert :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 97.99% 98.06% +0.06%
==========================================
Files 66 69 +3
Lines 2392 2424 +32
==========================================
+ Hits 2344 2377 +33
+ Misses 48 47 -1 ☔ View full report in Codecov by Sentry. |
|
Other than one change that I really should have noticed earlier (sorry!) and a tiny super-pedantic one, I think this is done! The only thing left would be some (placeholder) documentation in |
…n_power_map in test CMakeLists
|
@isaacy2012 are you happy for me to merge this? |
Yep, sounds good. Thanks for all your help and feedback :) |
Thank you for working on it! It's very much appreciated |
(Update of #162 with finalised name
cartesian_powerandcartesian_power_map)Attempts to partially address #138 regarding the
cartesian_power,cartesian_power_mapfunctionalities.Implementation centers around replacing
std::get<I>(self.bases_)incartesian_productwithself.base_forcartesian_power.Moves common logic across
cartesian_product,cartesian_powerand theirmapvariants to a common base trait classcartesian_basewith enum selectors for [product/power] and [tuple/map].