Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cartesian power and map #163

Merged
merged 49 commits into from
Jan 31, 2024

Conversation

isaacy2012
Copy link
Contributor

(Update of #162 with finalised name cartesian_power and cartesian_power_map)

Attempts to partially address #138 regarding the cartesian_power, cartesian_power_map functionalities.

Implementation centers around replacing std::get<I>(self.bases_) in cartesian_product with self.base_ for cartesian_power.

Moves common logic across cartesian_product, cartesian_power and their map variants to a common base trait class cartesian_base with enum selectors for [product/power] and [tuple/map].

isaacy2012 and others added 30 commits January 26, 2024 03:16
…c... functions

cartesian_product_with does not use the cartesian_default_read_traits as read_at behaviour is special for it.
…um selectors for product/power and tuple/map
Co-authored-by: Tristan Brindle <t.c.brindle@gmail.com>
Co-authored-by: Tristan Brindle <t.c.brindle@gmail.com>
@tcbrindle
Copy link
Owner

Hi @isaacy2012, it looks like this PR is using the "repeat" names, did you intend to change them back to "power"? :)

@isaacy2012
Copy link
Contributor Author

Hi @isaacy2012, it looks like this PR is using the "repeat" names, did you intend to change them back to "power"? :)

Oops sorry, forgot to push the revert :)

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19e87a3) 97.99% compared to head (4f02c0d) 98.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   97.99%   98.06%   +0.06%     
==========================================
  Files          66       69       +3     
  Lines        2392     2424      +32     
==========================================
+ Hits         2344     2377      +33     
+ Misses         48       47       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/flux/op/cartesian_power_map.hpp Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@tcbrindle
Copy link
Owner

Other than one change that I really should have noticed earlier (sorry!) and a tiny super-pedantic one, I think this is done!

The only thing left would be some (placeholder) documentation in docs/reference/adaptors.rst now that the name is finalised, but I can do that if you like because Sphinx can be really fussy about things.

@tcbrindle
Copy link
Owner

@isaacy2012 are you happy for me to merge this?

@isaacy2012
Copy link
Contributor Author

@isaacy2012 are you happy for me to merge this?

Yep, sounds good. Thanks for all your help and feedback :)

@tcbrindle
Copy link
Owner

@isaacy2012 are you happy for me to merge this?

Yep, sounds good. Thanks for all your help and feedback :)

Thank you for working on it! It's very much appreciated

@tcbrindle tcbrindle merged commit 0e50989 into tcbrindle:main Jan 31, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants