RAB: Integrate helper to rest of the tests #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
previously requested changes
Aug 16, 2024
test/built-ins/Object/defineProperties/typedarray-backed-by-resizable-buffer.js
Outdated
Show resolved
Hide resolved
test/built-ins/Object/defineProperties/typedarray-backed-by-resizable-buffer.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/slice/coerced-start-grow.js
Outdated
Show resolved
Hide resolved
|
The latest commit addresses all the review comments, and additionally simplifies superfluous |
Ms2ger
approved these changes
Aug 27, 2024
| @@ -11,16 +11,14 @@ includes: [compareArray.js, resizableArrayBufferUtils.js] | |||
| features: [resizable-arraybuffer] | |||
| ---*/ | |||
|
|
|||
| function ObjectDefinePropertyHelper(ta, index, value) { | |||
| function MayNeedBigInt(ta, value) { | |||
| if (ta instanceof BigInt64Array || ta instanceof BigUint64Array) { | |||
There was a problem hiding this comment.
Future work: MayNeedBigInt could go into the helper file
There was a problem hiding this comment.
I'll make a followup PR with this change, since this is defined across many files.
| @@ -33,7 +31,7 @@ for (let ctor of ctors) { | |||
| return 0; | |||
| } | |||
| }; | |||
| helper(fixedLength, evil, 8); | |||
| Object.defineProperty(fixedLength, evil, { value: MayNeedBigInt(fixedLength, 8) }); | |||
There was a problem hiding this comment.
Much more readable, thank you
Ms2ger
force-pushed
the
integrate-helper-to-PR3888
branch
from
ead3443 to
3859c2f
Compare
…t from each test file.
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
In particular: - Switching `TypedArray/out-of-bounds-has.js` and `TypedArray/out-of-bounds-get-and-set.js`` to include ctors of any size, accommodating for BigInt ctors. - Simplify superfluous helper definitions, renaming to a better description, and defined `MayNeedBigInt` also used in other RAB methods. - Duplicating `defineProperties/typedarray-backed-by-resizable-buffer.js` for `defineProperty`. - Removes previously renamed test.
Ms2ger
force-pushed
the
integrate-helper-to-PR3888
branch
from
3859c2f to
6854f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates
harness/resizableArrayBufferUtils.jshelper to the rest of the test files in PR #3888.