RAB: Integrate staging tests for the .every method #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
reviewed
May 8, 2024
ptomato
reviewed
May 10, 2024
test/built-ins/Array/prototype/every/resizable-buffer-grow-mid-iteration.js
Outdated
Show resolved
Hide resolved
@ptomato I just noticed I missed this comment. So indeed there were forgotten |
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
Jun 24, 2024
tc39#4074 (review) Adds forgotten tests from tc39#3888
ptomato
approved these changes
Jun 26, 2024
test/built-ins/Array/prototype/every/resizable-buffer-grow-mid-iteration.js
Outdated
Show resolved
Hide resolved
|
@ptomato reverted the scope changes but added documentation to makes things clearer and avoid potential future mistakes with the top level variables used. |
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
tc39#4074 (review) Adds forgotten tests from tc39#3888
New approach replaces ...Helper with CollectResize to make the tests easier to understand. In particular: - Replaced the need for '...Helper' abstractions with a more descriptive function 'ResizeBufferMidIteration', which the .every method can call directly. - Moved 'let values' back outside of the loops, together with a function definition 'ResizeBufferMidIteration' to persist the side effects that 'CollectValuesAndResize' has on 'values' but without having to define this inside every loop. + So this reverts commit d9a2bac and + this reverts commit 0bc2d66. - Added documentation.
ptomato
force-pushed
the
RAB-test-method-every
branch
from
3fe52ab to
5a80b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of Array.prototype and TypedArray.prototype
This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js