Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update two constructor tests of Array.fromAsync #3926

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Update two constructor tests of Array.fromAsync #3926

merged 3 commits into from
Sep 19, 2023

Conversation

rmahdav
Copy link
Contributor

@rmahdav rmahdav commented Sep 15, 2023

Based on this fix on Array.fromAsync spec to avoid calling constructor twice, the following two tests needed to be updated:
built-ins/Array/fromAsync/this-constructor
built-ins/Array/fromAsync/this-constructor-operations

@rmahdav rmahdav requested a review from a team as a code owner September 15, 2023 22:23
@ljharb ljharb mentioned this pull request Sep 15, 2023
Closed
ptomato
ptomato approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks good. Would you mind removing the comment as well before we merge it in?

test/built-ins/Array/fromAsync/this-constructor-operations.js Outdated Show resolved Hide resolved
@ptomato ptomato added awaiting author has consensus This has committee consensus labels Sep 18, 2023
ptomato
ptomato approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato ptomato merged commit 79f0878 into tc39:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
has consensus This has committee consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmahdav @ptomato