Temporal: Add Temporal era/eraYear tests #3792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for Temporal PR: tc39/proposal-temporal#2472
The above PR makes PrepareTemporalFields not validate that either both or none of era/eraYear are present. In all cases (except when fields is to be converted to a PlainTime, in which case it doesn't matter), that is already done immediately afterwards anyway by one of the dateFromFields/yearMonthFromFields/monthDayFromFields Calendar methods, which is where we think this validation belongs.
See issue: tc39/proposal-temporal#2465