Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that IteratorClose suppresses GetMethod errors #2565

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Test that IteratorClose suppresses GetMethod errors #2565

merged 2 commits into from
Apr 2, 2020

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh force-pushed the iteratorclose-suppress-getmethod-errors branch from f3b87f2 to e8b0f40 Compare April 1, 2020 05:49
@shvaikalesh shvaikalesh marked this pull request as ready for review April 1, 2020 05:52
@shvaikalesh shvaikalesh mentioned this pull request Apr 1, 2020
Merged
rwaldron
rwaldron approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These make sense to me, however I would like either @zenparsing or @LeszekSwirski to take a look and verify

@LeszekSwirski
Copy link

Looks good as far as I can tell.

@rwaldron rwaldron merged commit df59ad6 into tc39:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@devsnek devsnek devsnek left review comments

@rwaldron rwaldron rwaldron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shvaikalesh @LeszekSwirski @rwaldron @ljharb @devsnek