Skip to content

Commit

Permalink
Add IteratorClose tests
Browse files Browse the repository at this point in the history
  • Loading branch information
shvaikalesh authored and rwaldron committed Apr 2, 2020
1 parent 966fc11 commit fccd9c4
Show file tree
Hide file tree
Showing 4 changed files with 157 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
// Copyright (C) 2015 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
es6id: 13.6.4.13
esid: sec-iteratorclose
description: >
If retrieving an iterator's `return` method generates an error while
closing the iterator, the error should be forwarded to the runtime.
If retrieving an iterator's `return` method generates an error while
closing the iterator with non-throw completion, the error should be
forwarded to the runtime.
info: |
IteratorClose ( iteratorRecord, completion )
[...]
4. Let innerResult be GetMethod(iterator, "return").
5. If innerResult.[[Type]] is normal,
[...]
6. If completion.[[Type]] is throw, return Completion(completion).
7. If innerResult.[[Type]] is throw, return Completion(innerResult).
GetMethod ( V, P )
[...]
2. Let func be ? GetV(V, P).
features: [Symbol.iterator]
---*/

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Copyright (C) 2020 Alexey Shvayka. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorclose
description: >
If retrieving an iterator's `return` method generates an error while
closing the iterator with non-throw completion, the error should be
forwarded to the runtime.
info: |
IteratorClose ( iteratorRecord, completion )
[...]
4. Let innerResult be GetMethod(iterator, "return").
5. If innerResult.[[Type]] is normal,
[...]
6. If completion.[[Type]] is throw, return Completion(completion).
7. If innerResult.[[Type]] is throw, return Completion(innerResult).
GetMethod ( V, P )
[...]
2. Let func be ? GetV(V, P).
3. If func is either undefined or null, return undefined.
4. If IsCallable(func) is false, throw a TypeError exception.
features: [Symbol.iterator]
---*/

var iterable = {};
var iterationCount = 0;

iterable[Symbol.iterator] = function() {
return {
next: function() {
return { done: false, value: null };
},
return: 1,
};
};

assert.throws(TypeError, function() {
for (var x of iterable) {
iterationCount += 1;
break;
}
});

assert.sameValue(iterationCount, 1, 'The loop body is evaluated');
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// Copyright (C) 2020 Alexey Shvayka. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorclose
description: >
If retrieving an iterator's `return` method generates an error while
closing the iterator with throw completion, this error should be suppressed.
info: |
IteratorClose ( iteratorRecord, completion )
[...]
4. Let innerResult be GetMethod(iterator, "return").
5. If innerResult.[[Type]] is normal,
[...]
6. If completion.[[Type]] is throw, return Completion(completion).
7. If innerResult.[[Type]] is throw, return Completion(innerResult).
GetMethod ( V, P )
[...]
2. Let func be ? GetV(V, P).
features: [Symbol.iterator]
---*/

var iterable = {};
var iterationCount = 0;

iterable[Symbol.iterator] = function() {
return {
next: function() {
return { done: false, value: null };
},
get return() {
throw { name: 'inner error' };
},
};
};

assert.throws(Test262Error, function() {
for (var x of iterable) {
iterationCount += 1;
throw new Test262Error('should not be overriden');
}
});

assert.sameValue(iterationCount, 1, 'The loop body is evaluated');
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// Copyright (C) 2020 Alexey Shvayka. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorclose
description: >
If retrieving an iterator's `return` method generates an error while
closing the iterator with throw completion, this error should be suppressed.
info: |
IteratorClose ( iteratorRecord, completion )
[...]
4. Let innerResult be GetMethod(iterator, "return").
5. If innerResult.[[Type]] is normal,
[...]
6. If completion.[[Type]] is throw, return Completion(completion).
7. If innerResult.[[Type]] is throw, return Completion(innerResult).
GetMethod ( V, P )
[...]
2. Let func be ? GetV(V, P).
3. If func is either undefined or null, return undefined.
4. If IsCallable(func) is false, throw a TypeError exception.
features: [Symbol.iterator]
---*/

var iterable = {};
var iterationCount = 0;

iterable[Symbol.iterator] = function() {
return {
next: function() {
return { done: false, value: null };
},
return: 'str',
};
};

assert.throws(Test262Error, function() {
for (var x of iterable) {
iterationCount += 1;
throw new Test262Error('should not be overriden');
}
});

assert.sameValue(iterationCount, 1, 'The loop body is evaluated');

0 comments on commit fccd9c4

Please sign in to comment.