This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Clarifies the definition of column as discussed #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledan
reviewed
Jul 11, 2023
source-map.bs
Outdated
| the format. For JavaScript and CSS based source maps are defined to be in | ||
| UTF-16 code units analogous to JavaScript string indexes. That means that | ||
| "A" (`LATIN CAPITAL LETTER A`) measures 1 code unit, and "🔥" (`FIRE`) measures | ||
| 2 code units. Source maps for other formats (for instance web assembly) might |
There was a problem hiding this comment.
Let's document the Wasm column meaning, while we're here. (But OK to land this without that, if needed)
Nit: WebAssembly, not web assembly
There was a problem hiding this comment.
I would prefer to merge and then follow up with the WebAssembly definition later.
littledan
approved these changes
Jul 12, 2023
github-actions bot
added a commit
that referenced
this pull request
Jul 12, 2023
SHA: 5579ed3 Reason: push, by littledan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs tc39/ecma426#5