This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a bug in my source URL resolution where I resolved
sourceMappingUrl
andsourceRoot
, then used that result to resolvesource
. The under-specified behavior is thatsourceRoot
is prepended (treating it as a directory) tosource
, then resolved usingsourceMappingUrl
as the base.Implementations:
source-map
: computeSourceURL and joinOpen questions:
source = null
?"null"
source-map
treats it as""
data:
URIs (the basic URL parser will throw an error).href
source-map
throwsblob