This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Updated the spec to clearly define usage of the sourcemap comment formats #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Regarding the failing IPR check: ideally you should be onboarded as a Mozilla delegate so that it's explicit that your contribution are on behalf of your company (cc @dminor could it be done? 🙂), but if it will be a blocker for merging this change we can temporary add an exception for your username. |
What do i need to do to onboard? |
|
@bomsy is now a TC39 delegate, so IPR is good :) |
nicolo-ribaudo
approved these changes
Dec 4, 2023
nicolo-ribaudo
force-pushed
the
supported-comment-formats
branch
from
7d9a686 to
e2fe1b3
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 18, 2024
SHA: fabdabd Reason: push, by jkup Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #54. Updated the supported comments based of the decisions at the last meeting.