This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Introduce a definition for Wasm columns #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jul 27, 2023
source-map.bs
Outdated
| diverge from this. | ||
| 2 code units. For WebAssembly, columns are defined as byte offsets from the start | ||
| of the binary content (the line number is always defined as 1). Source maps for | ||
| other formats might diverge from this. |
There was a problem hiding this comment.
nit: I think "format" has been a bad choice of wording in the original (above, it mostly refers to "source map format"), but it's worse now, now that the example is missing.
I'm not sure I'd have understood that "format" refers to other languages / binary types.
Following the previous sentence, it might also refer to other formats of WebAssembly formats.
Could probably be "content types" or "languages" (above it says "although the format itself is language agnostic", so the term "language was already introduced")?
There was a problem hiding this comment.
Maybe, "kinds of original source" or "types of original source"? @JannikGM WDYT?
ghost
reviewed
Jul 27, 2023
littledan
approved these changes
Aug 1, 2023
github-actions bot
added a commit
that referenced
this pull request
Aug 1, 2023
SHA: 1ac019b Reason: push, by littledan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce columns definition for WebAssembly based on the current browser implementations and this PR