Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Small batch of changes #3091

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Editorial: Small batch of changes #3091

wants to merge 5 commits into from

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Feb 15, 2025

  • Add %Temporal% to list of well-known intrinsics
  • Update test262 tests
  • Fix a few nonconformances in the reference code pointed out by @anba

@ptomato
Editorial: Add %Temporal% to table of well-known intrinsic objects
64957ff 
See: #3087
@ptomato
Polyfill: Fix handling of hour12/hourCycle to conform to spec
98fbde2 
The strategy of caching the output of DTF resolvedOptions() failed in the
case of hour12/hourCycle, because those options are silently dropped if
the chosen format does not include an hour component. Manually add them to
the cached resolvedOptions object if the user included them.

See: #3065
@ptomato
Polyfill: Fix parsing of calendar identifier from time-only string
53b33c0 
https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalcalendarstring
ParseTemporalCalendarString specifies to try to parse the string as
TemporalDateTimeString[+Zoned], TemporalDateTimeString[~Zoned],
TemporalInstantString, TemporalTimeString, TemporalMonthDayString, and
TemporalYearMonthString consecutively until one succeeds. I always thought
TemporalTimeString would be handled by ParseISODateTime in the polyfill,
but it seems I was wrong about that.

See: #3090
@ptomato
Polyfill: Fix formatting PlainDateTime with both dateStyle and timeStyle
b8c0e6d 
Adjusting the options to not print the time zone name in timeStyle long or
full (#2795) inadvertently regressed formatting a PlainDateTime with both
dateStyle and timeStyle specified.

See: #3061
@ptomato
Update test262
c9d9778
@codecov Codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.05%. Comparing base (69f46d5) to head (c9d9778).

Files with missing lines Patch % Lines
polyfill/lib/intl.mjs 44.44% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3091      +/-   ##
==========================================
- Coverage   96.14%   96.05%   -0.10%     
==========================================
  Files          21       21              
  Lines        9928     9950      +22     
  Branches     1801     1802       +1     
==========================================
+ Hits         9545     9557      +12     
- Misses        336      346      +10     
  Partials       47       47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ptomato