Normative: Treat daysInMonth as the count of days in a month
#2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2484 +/- ##
==========================================
+ Coverage 96.16% 96.17% +0.01%
==========================================
Files 20 20
Lines 11289 11300 +11
Branches 2163 2164 +1
==========================================
+ Hits 10856 10868 +12
Misses 369 369
+ Partials 64 63 -1
|
cjtenny
force-pushed
the
dayInMonthIsCount
branch
from
f405b6a
to
ea6bdd6
Compare
ptomato
reviewed
Jan 19, 2023
guijemont
force-pushed
the
dayInMonthIsCount
branch
3 times, most recently
from
6830ad1
to
c4d83ae
Compare
…r of the last day Updates PlainYearMonth arithmetic accordingly and clarifies language around non-ISO calendar operations. Fixes #1315 Co-authored-by: Guillaume Emont <guijemont@igalia.com>
|
This PR reached consensus in the January 2023 TC39 meeting. |
ptomato
force-pushed
the
dayInMonthIsCount
branch
from
c4d83ae
to
e604f37
Compare
ptomato
approved these changes
Apr 28, 2023
Is there already an issue created for docs and non-ISO calendars? |
justingrant
added a commit
that referenced
this pull request
May 2, 2023
Replaces a use of `ObjectCreate` followed by `CopyDataProperties` with `CopyOptions`. This pattern is used everywhere else in Temporal but was missed in #2484.
This was referenced May 2, 2023
Ms2ger
pushed a commit
that referenced
this pull request
May 2, 2023
Replaces a use of `ObjectCreate` followed by `CopyDataProperties` with `CopyOptions`. This pattern is used everywhere else in Temporal but was missed in #2484.
|
I had determined along the line somewhere that they didn't seem necessary, but if you see some then please do open an issue. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 18, 2023
…earMonth. r=spidermonkey-reviewers,sfink Implement the changes from <tc39/proposal-temporal#2484>. Differential Revision: https://phabricator.services.mozilla.com/D182049
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 19, 2023
…earMonth. r=spidermonkey-reviewers,sfink Implement the changes from <tc39/proposal-temporal#2484>. Differential Revision: https://phabricator.services.mozilla.com/D182049
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 21, 2023
…earMonth. r=spidermonkey-reviewers,sfink Implement the changes from <tc39/proposal-temporal#2484>. Differential Revision: https://phabricator.services.mozilla.com/D182049 UltraBlame original commit: 2aff072a94c4b7ae26778e7308f853ab008bd8e2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 21, 2023
…earMonth. r=spidermonkey-reviewers,sfink Implement the changes from <tc39/proposal-temporal#2484>. Differential Revision: https://phabricator.services.mozilla.com/D182049 UltraBlame original commit: 2aff072a94c4b7ae26778e7308f853ab008bd8e2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 21, 2023
…earMonth. r=spidermonkey-reviewers,sfink Implement the changes from <tc39/proposal-temporal#2484>. Differential Revision: https://phabricator.services.mozilla.com/D182049 UltraBlame original commit: 2aff072a94c4b7ae26778e7308f853ab008bd8e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1315.
Updates Plain Year Month arithmetic to use a version of
.with({ day: 1 }).add({ months: 1 }).subtract({ days: 1}).dayto get the index of the last day of the month. Chose this over the alternative of.with({ day: 1 }).add({ days: yearMonth.daysInMonth() - 1]}).daybeacuse theGetMethod(calendar, "dateAdd")can be reduced to one GetMethod.Updates polyfill, no changes needed to non-ISO calendars because there are no skipped days in any of the calendars it implements.
Updates to docs pending, will update PR when ready.
Will prepare separate editorial PR to make language of CalendarDateDaysIn{Week,Month,Year} and CalendarDateMonthsInYear more consistent, but current phrasing is correct - nothing needed to address this.