Editorial: More structured headers #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsValidISODate, GetEpochFromISOParts, ISODateTimeWithinLimits, IsValidTime, GetIANATimeZoneEpochValue, GetIANATimeZoneOffsetNanoseconds, GetIANATimeZoneNextTransition, GetIANATimeZonePreviousTransition All of these operations never return a completion record, so we can remove the corresponding assertions about completion records.
…ISOParts Some existing algorithms treated this as a BigInt and some as a mathematical value. It's really six of one, half a dozen of the other, which is more convenient. I chose BigInt because that fits with the internal EpochNanoseconds slot of Instant and ZonedDateTime being a BigInt.
These notes were missing from GetIANATimeZonePreviousTransition and GetIANATimeZoneNextTransition. All operations dealing with the implementation's internal time zone database need to have this note.
ptomato
commented
Apr 28, 2022
| _millisecond_: an integer between 0 and 999 inclusive, | ||
| _microsecond_: an integer between 0 and 999 inclusive, | ||
| _nanosecond_: an integer between 0 and 999 inclusive, | ||
| ): a BigInt |
There was a problem hiding this comment.
This was treated as integer in some places and BigInt in others. I picked BigInt but could go either way.
Codecov Report
@@ Coverage Diff @@
## main #2161 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 19 19
Lines 10905 10905
Branches 1693 1693
=======================================
Hits 9818 9818
Misses 1073 1073
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Ms2ger
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a few editorial fixes around time zones, in preparation for #519.