Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify ZonedDateTime.toPlain{YearMonth,MonthDay}() #1157

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Nov 7, 2020

See: #569

@ptomato ptomato requested review from Ms2ger and ryzokuken November 7, 2020 00:49
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #1157 (53d5446) into main (5930868) will decrease coverage by 3.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   93.55%   90.54%   -3.01%     
==========================================
  Files          19       17       -2     
  Lines        7961     8740     +779     
  Branches     1264     1231      -33     
==========================================
+ Hits         7448     7914     +466     
- Misses        506      815     +309     
- Partials        7       11       +4     
Flag Coverage Δ
test262 ?
tests 90.54% <ø> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/shim.mjs
polyfill/lib/legacydate.mjs
polyfill/lib/slots.mjs
polyfill/lib/intrinsicclass.mjs
lib/calendar.mjs 77.59% <0.00%> (ø)
lib/regex.mjs 100.00% <0.00%> (ø)
lib/plainyearmonth.mjs 89.80% <0.00%> (ø)
lib/plainmonthday.mjs 83.79% <0.00%> (ø)
lib/zoneddatetime.mjs 89.72% <0.00%> (ø)
lib/timezone.mjs 89.91% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116256a...bb8cb5f. Read the comment docs.

spec/zoneddatetime.html Outdated Show resolved Hide resolved
spec/zoneddatetime.html Outdated Show resolved Hide resolved
And make a small adjustment to the polyfill to match.

See: #569
@ptomato ptomato requested a review from Ms2ger November 9, 2020 16:38
@ptomato
Copy link
Collaborator Author

ptomato commented Nov 9, 2020

Thanks. Made the same change to the polyfill as well.

@Ms2ger Ms2ger merged commit 5d5ca83 into main Nov 10, 2020
@Ms2ger Ms2ger deleted the zoneddatetime-10 branch November 10, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants